Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cursor pagination #8

Draft
wants to merge 4 commits into
base: develop
Choose a base branch
from
Draft

Cursor pagination #8

wants to merge 4 commits into from

Conversation

KondukterCRO
Copy link
Contributor

No description provided.

@KondukterCRO KondukterCRO marked this pull request as draft September 12, 2023 11:14
ghost
ghost reviewed Sep 12, 2023
View reviewed changes
src/Definition/Model/Request/Pagination/CursorInterface.php Outdated

namespace Undabot\JsonApi\Definition\Model\Request\Pagination;

interface CursorInterface extends PaginationInterface
Copy link

@ghost ghost Sep 12, 2023 •
edited by ghost
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add extension of getOffset here:

/** @throws \LogicException */
public function getOffset(): int;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@KondukterCRO